Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove EOL kubernetes version #617

Merged
merged 4 commits into from
Apr 12, 2022
Merged

Remove EOL kubernetes version #617

merged 4 commits into from
Apr 12, 2022

Conversation

ngoyal16
Copy link
Contributor

Issue #, if available:

Description of changes:

EOL kubernetes version support compatiblity test removed

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Merge from upstream
Signed-off-by: Nitin Goyal <nitingoyal.dev@gmail.com>
@ngoyal16 ngoyal16 requested a review from a team as a code owner April 11, 2022 04:57
@ngoyal16 ngoyal16 requested a review from snay2 April 11, 2022 04:57
Copy link
Contributor

@snay2 snay2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @ngoyal16, thanks for staying on top of these version updates!

Historically, we've kept the 6 most recent k8s versions in the testing matrix. I'm fine with removing 1.17 now, but can you also add 1.23 into the matrix as well?

(Looks like 1.24 should be released next week and EKS should be dropping 1.18 support soon, so we can come back and update this matrix again in a few weeks.)

@ngoyal16
Copy link
Contributor Author

@snay2 Kubernetes v1.18 support is already droped by EKS on 31st march, 2022.

also could you provide the docker kind image url for the v1.23 for testing

@snay2
Copy link
Contributor

snay2 commented Apr 11, 2022

Good point, we can remove 1.18 as soon as 1.24 is released this month.

The latest minor version of 1.23 available, per https://hub.docker.com/r/kindest/node/tags, is 1.23.5. Here's the image identifier:

kindest/node@sha256:1a72748086bc24ed6163de1d1e33cc0e2eb5a1eb5ebffdb15b53c3bcd5376a6f

(I got that with this command, if you want to verify:)

docker pull kindest/node:v1.23.5 && docker inspect kindest/node:v1.23.5 | jq ".[0].RepoDigests[0]"

Signed-off-by: Nitin Goyal <nitingoyal.dev@gmail.com>
@ngoyal16
Copy link
Contributor Author

@snay2 1.23 support is added

@ngoyal16 ngoyal16 requested a review from snay2 April 12, 2022 04:00
Copy link
Contributor

@snay2 snay2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants